Repository navigation
Refuse set() on a read-only instance - #1700
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On an instance opened with
MMKV_READ_ONLY,set()that overwrites the only key of a single-process store writes into the read-only mapping and the process dies on the write fault. The append path refuses read-only insideensureMemorySize(), but that overwrite takes the in-place override path, which never grows the file.setDataForKey, which everyset()overload reaches, now returns false on a read-only instance with the same warningremoveValueForKeyandremoveValuesForKeysgive.The new
testReadOnlyRejectsSetin POSIX/demo/UnitTest.cpp killsUnitTeston dev (SIGSEGV on Linux) and passes with the change; the four ctest targets pass.