fix(cubelet): register metric plugin to enable /v1/metrics/scheduler endpoint#301
Merged
kinwin-ustc merged 1 commit intoMay 19, 2026
Merged
Conversation
2c54d3d to
db94e3f
Compare
…endpoint The metric plugin was missing from builtins.go, so its init() never ran and the /v1/metrics/scheduler endpoint returned 404. Adding the blank import so the plugin registers with containerd's plugin system. Signed-off-by: chenggui53 <chenggui53@gmail.com>
db94e3f to
28ba109
Compare
Collaborator
|
/cubebot review |
|
Claude finished @kinwin-ustc's task in 44s —— View job Code ReviewSummaryThis PR adds a blank import for the metric plugin ( What was checked
FindingLGTM — the change is correct and minimal. The single-line addition is exactly what's needed. No issues found. Minor note (pre-existing, not related to this PR)There's a duplicate import of
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metric plugin was missing from builtins.go, so its init() never ran and the /v1/metrics/scheduler endpoint returned 404. Adding the blank import so the plugin registers with containerd's plugin system.