fix(local_git): add interface func stubs for git local provider#1455
Merged
mrT23 merged 1 commit intoJan 18, 2025
Merged
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨Explore these optional code suggestions:
|
Contributor
|
👍 |
mrT23
approved these changes
Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
This PR adds the necessary method stubs to the LocalGitProvider interface to ensure compatibility when running pr_agent with a local Git provider.
Without these changes, running with the local provider currently results in the following error:
TypeError: Can't instantiate abstract class LocalGitProvider without an implementation for abstract methods 'add_eyes_reaction', 'get_commit_messages', 'get_repo_settings', 'remove_reaction'PR Type
Bug fix
Description
Added missing method stubs to
LocalGitProviderinterface.Ensured compatibility with local Git provider implementation.
Prevented
TypeErrorwhen instantiatingLocalGitProvider.Changes walkthrough 📝
local_git_provider.py
Added missing method stubs to LocalGitProviderpr_agent/git_providers/local_git_provider.py
add_eyes_reaction,get_commit_messages,get_repo_settings, andremove_reaction.