fix(gitlab): add missing ssl_verify parameter for private_token auth#2173
Merged
naorpeled merged 1 commit intoJan 30, 2026
Merged
Conversation
When using private_token authentication (GITLAB.AUTH_TYPE = 'private_token'), the ssl_verify setting was not being passed to the GitLab client constructor. This caused SSL certificate verification to remain enabled even when ssl_verify was explicitly set to false in the configuration, breaking connections to self-hosted GitLab instances with self-signed certificates. The oauth_token authentication path correctly includes ssl_verify, but the private_token path was missing it. This commit adds the missing parameter to ensure consistent behavior for both authentication methods.
Contributor
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
When using
private_tokenauthentication (GITLAB.AUTH_TYPE = "private_token"), thessl_verifysetting was not being passed to the GitLab client constructor.Problem
The
oauth_tokenauthentication path correctly includesssl_verify:But the
private_tokenpath was missing it:This caused SSL certificate verification to remain enabled even when
ssl_verifywas explicitly set tofalsein the configuration, breaking connections to self-hosted GitLab instances with self-signed certificates.Solution
Add the missing
ssl_verify=ssl_verifyparameter to theprivate_tokenauthentication path to ensure consistent behavior for both authentication methods.Testing
Tested on a self-hosted GitLab instance with self-signed certificate:
SSL: CERTIFICATE_VERIFY_FAILEDerror even withssl_verify = falsessl_verify = falsePR Type
Bug fix
Description
Add missing
ssl_verifyparameter to private_token authentication pathEnsures consistent SSL certificate handling across both auth methods
Fixes connections to self-hosted GitLab with self-signed certificates
Diagram Walkthrough
File Walkthrough
gitlab_provider.py
Add ssl_verify parameter to private_token authpr_agent/git_providers/gitlab_provider.py
ssl_verify=ssl_verifyparameter to the private_token GitLabclient initialization
setting for private_token authentication
implementation