Fixes #3136 The deleteString function was unconditionally resetting child pointers, corrupting words that share prefixes. Fixed by only pruning nodes when they have no children and are not the end of another word. Added a hasChildren() helper method and regression tests.#3142
Open
ckprojects77 wants to merge 1 commit into
Open
Fixes #3136 The deleteString function was unconditionally resetting child pointers, corrupting words that share prefixes. Fixed by only pruning nodes when they have no children and are not the end of another word. Added a hasChildren() helper method and regression tests.#3142ckprojects77 wants to merge 1 commit into
ckprojects77 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3136
The
deleteStringfunction had two bugs:thisinstead ofarr[j], so thefunction never actually descended the trie.
any words that shared a prefix (e.g. deleting "Hello" would destroy "Hell").
Fix: corrected the recursive call to
arr[j]->deleteString(...)and addedconditional pruning — nodes are only removed when they have no children and
are not the end of another word. Added a
hasChildren()helper and regressiontests covering the shared-prefix case.
Checklist
Notes: Corrects recursive traversal bug and shared-prefix corruption in trie::deleteString.