Fix missing function pointer to setWindowTitleBar for X11 platform#17
Open
valerioformato wants to merge 1 commit intoTheCherno:masterfrom
Open
Fix missing function pointer to setWindowTitleBar for X11 platform#17valerioformato wants to merge 1 commit intoTheCherno:masterfrom
valerioformato wants to merge 1 commit intoTheCherno:masterfrom
Conversation
The extra field `setWindowTitleBar` was wrongly initialized for the X11 platform in x11_init.c. This led to crashes during window initialization, and also in test applications such as glfwinfo. (It is possible that it is still missing also for other platforms)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra field
setWindowTitleBarwas wrongly initialized for the X11 platform in x11_init.c. This led to crashes during window initialization, and also in test applications such as glfwinfo.(It is possible that it is still missing for other platforms as well)
p.s: I came across this issue while trying to add linux support to Walnut :)