Fido2: Support for user handles#1
Open
p1gp1g wants to merge 1 commit intoTheMartinizer:credential_selectionfrom
Open
Fido2: Support for user handles#1p1gp1g wants to merge 1 commit intoTheMartinizer:credential_selectionfrom
p1gp1g wants to merge 1 commit intoTheMartinizer:credential_selectionfrom
Conversation
p1gp1g
commented
May 6, 2025
| const val TAG = "FidoLockStore" | ||
|
|
||
| const val DATABASE_VERSION = 1 | ||
| const val DATABASE_VERSION = 2 |
Author
There was a problem hiding this comment.
I know your patch isn't merged upstream yet, but I'm already using your patch; so if you want to avoid the migration, can you at least keep version = 2 ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some website require having the user handle, for example passkeys.io
This commit adds this support
PS: I'll use yours patches for the credential selection to HW Fdo2 Provider