Open
Conversation
cb8489c to
c356fa1
Compare
Contributor
Author
|
I switched the implementation to videojs instead of shaka because it was a pain to switch between html5 video for mp4/basic videos & shaka for hls/dash. |
Contributor
Author
|
I added new public APIs that are only used for the web right now:
|
682b59a to
79f243c
Compare
Contributor
Author
|
hey @KrzysztofMoch any update on getting this reviewed or if I need to do something to move this PR forward? I've been using my branch for the past few months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initial implementation for the web. I decided to use shaka player to support more advanced features (like hls/dash/ads/drm...)
It's missing some features for now (will implement before marking this pr as ready):
external subtitles supportmetadata notificationerror handlingMissing features i don't plan on implementing:
Please ignore biome/nix stuff, i'll remove them once the pr is ready & fix style issues.
Motivation
Fixes #4605
Note that i found some missing APIs while implementing this:
missing-> added but only used on the webmimeTypein sourcestartTimemissing audio/video selections->multi audiosmulti variants (hls/dash only)Test plan
For now i'm just making this PR to share the progress and the initial ideas, my next step is to try those changes with the example app and then with kyoo.