fix(android): controls always show in fullscreen #4813
Open
robertert wants to merge 1 commit intoTheWidlarzGroup:support/6.x.xfrom
Open
fix(android): controls always show in fullscreen #4813robertert wants to merge 1 commit intoTheWidlarzGroup:support/6.x.xfrom
robertert wants to merge 1 commit intoTheWidlarzGroup:support/6.x.xfrom
Conversation
github-project-automation
bot
moved this to To Triage
in React Native Video - Public Roadmap
Contributor
|
Thanks for the PR! |
moskalakamil
approved these changes
Jan 31, 2026
|
@robertert could this be merged? |
| private void updateControllerConfig() { | ||
| if (exoPlayerView == null) return; | ||
|
|
||
| // Extra configuration for proper touch handling |
Collaborator
There was a problem hiding this comment.
Could you delete this comment?
| private void refreshControlsStyles() { | ||
| if (exoPlayerView == null || player == null || !controls) return; | ||
| if (exoPlayerView == null || player == null) return; | ||
| // Always update controller visibility to ensure it matches current state |
Collaborator
There was a problem hiding this comment.
Could you delete this comment?
Comment on lines
+2644
to
+2646
| if (exoPlayerView != null) { | ||
| exoPlayerView.showController(); | ||
| } |
Comment on lines
+2709
to
+2711
| boolean shouldShowControls = controls || isFullscreen; | ||
| if (shouldShowControls) { | ||
| updateControllerConfig(); |
Collaborator
There was a problem hiding this comment.
What about the configuration we deleted?
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where player controls were not visible in fullscreen mode when controls={false} on Android (version >= 6.16.0). The fix ensures controls are always shown in fullscreen mode regardless of the controls prop value, which aligns with the documented behavior.
Changes:
- Updated controller visibility logic to use
controls || isFullscreeninstead ofcontrols && !controlsConfig.getHideFullscreen() - Refactored and simplified controller visibility management by removing redundant code
- Added explicit controller show/hide calls when entering/exiting fullscreen mode
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4751
Resolves an issue where player controls were not visible in Fullscreen mode when controls={false} on Android
Changes: