This repository was archived by the owner on Jul 3, 2022. It is now read-only.
Map by KeyPath#212
Merged
Thomvis merged 4 commits intoThomvis:masterfrom Feb 18, 2020
RomanPodymov:master
Merged
Conversation
RomanPodymov
requested review from
Thomvis,
alickbass,
arnopoulos,
danj-stripe,
kimdv,
oysta,
phimage and
possen
Owner
|
Hi, thanks for contributing to BrightFutures! I like your contribution and I'd love to merge it after discussing one thought I had while going through the changes. Do you think you could leverage the closure-based map implementation to simplify the new map function? So instead of calling into Let me know what you think! |
Contributor
Author
|
Hello @Thomvis |
Owner
|
Thanks for making these changes. I've merged the PR! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Thank you for BrightFutures.
In this pull request I added
func map<U>(_ context: @escaping ExecutionContext, keyPath: KeyPath<Value.Value, U>) -> Future<U, Value.Error>. It is similar tomapthat you already have, but accepts KeyPath instead of a closure.