Changes to track timely's #597#538
Merged
frankmcsherry merged 3 commits intoNov 11, 2024
Merged
Conversation
frankmcsherry
force-pushed
the
track_timely_597
branch
from
c1b2106 to
a838b7b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Largely local rewrites, with a discussion to have around
RefOrMutturning in to&mut. Works out, but a bunch of things look complicated now, e.g.PushInto<&'a mut Thing>. It's possible that with an understanding that these are all going to be owned going forward, and then "borrowing" would be internal, that they could perhaps becomePushInto<Thing>.