Remove Filter and Freeze wrappers#644
Merged
frankmcsherry merged 2 commits intoTimelyDataflow:masterfrom Sep 12, 2025
Merged
Conversation
antiguru
approved these changes
Sep 12, 2025
Member
antiguru
left a comment
There was a problem hiding this comment.
I don't mind removing some untested code! Easy enough to get it back.
Member
Author
|
Further pondering, and I'm feeling even better. The filter wrapper is something that shouldn't be too hard to implement in user logic, e.g. in your join closure look at the keys and values and nope out appropriately. It would be great if the trace did this for you, but there's a perf tax that comes with it, and it's just a weird space to try to be in (moving per-row logic around, from user code into arrangement spackle). The freeze wrapper is neat but I'd be baffled if anyone used it successfully. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have various trace wrappers, each of which imposes a bit of a tax on modifying things and act as constraints on how we can evolve things. The
FilterandFreezewrappers are to my understanding not used, and are hard to use (they provide a new type of trace/batch/cursor, which is hard to hide behind an abstraction).This PR removes them, and leaves the remaining wrappers as roughly the timestamp modifying wrappers (
enter,enter_at, andfrontier) plus thercwrapper which I think is less a wrapper and more just a standard tool.