Add reconnectBlocking method with timeout#1251
Closed
sfeilmeier wants to merge 3 commits intoTooTallNate:masterfrom
Closed
Add reconnectBlocking method with timeout#1251sfeilmeier wants to merge 3 commits intoTooTallNate:masterfrom
reconnectBlocking method with timeout#1251sfeilmeier wants to merge 3 commits intoTooTallNate:masterfrom
Conversation
Collaborator
|
It's up to @marci4 to decide, but in any case, the current version is 1.5.3 so the javadoc comment should have |
Collaborator
|
I would really prefer a issue to test than another api. |
lukasrgr
pushed a commit
to OpenEMS/openems
that referenced
this pull request
May 24, 2023
`WebSocketClient#reset()` method may block on `closeLatch.await();`. This PR rewrites the entire method via Reflection to be able to call `closeLatch.await(CONNECT_TIMEOUT_SECONDS, TimeUnit.SECONDS);` instead. Ideally this should be solved upstream in TooTallNate/Java-WebSocket#1251. Somehow related issue: TooTallNate/Java-WebSocket#1236 Co-authored-by: Michael Grill <michael.grill@fenecon.de> Reviewed-on: https://git.intranet.fenecon.de/FENECON/fems/pulls/437 Reviewed-by: Michael Grill <michael.grill@fenecon.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
reconnectBlocking(long timeout, TimeUnit timeUnit)method similarly to the existingconnectBlocking(long timeout, TimeUnit timeUnit)method.Related Issue
none
Motivation and Context
In certain (non-reproduable) situations it seems the current reconnectBlocking method does neither finish nor abort. The idea here is to use the same approach with
connectLatchas is already existing with theconnectBlockingmethod.How Has This Been Tested?
does not apply
Types of changes
Checklist: