Skip to content

fix make check and fix usage with node 0.10#90

Merged
bahamas10 merged 1 commit intomasterfrom
dave-fix-make-check
Nov 5, 2019
Merged

fix make check and fix usage with node 0.10#90
bahamas10 merged 1 commit intomasterfrom
dave-fix-make-check

Conversation

@bahamas10
Copy link
Contributor

$ make check
deps/javascriptlint/build/install/jsl --nologo --nosummary --conf=tools/jsl.node.conf lib/index.js lib/verify.js lib/utils.js lib/parser.js lib/signer.js
/home/dave/dev/node-http-signature/lib/index.js
/home/dave/dev/node-http-signature/lib/verify.js
/home/dave/dev/node-http-signature/lib/utils.js
/home/dave/dev/node-http-signature/lib/parser.js
/home/dave/dev/node-http-signature/lib/signer.js
deps/jsstyle/jsstyle -f tools/jsstyle.conf lib/index.js lib/verify.js lib/utils.js lib/parser.js lib/signer.js
check ok

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguably the main thing for this fix and the commit message should be about fixing node 0.10 usage, broken by #83 and released in version 1.3.0.

@bahamas10 bahamas10 merged commit db839cd into master Nov 5, 2019
@bahamas10 bahamas10 deleted the dave-fix-make-check branch November 5, 2019 21:45
@trentm trentm changed the title fix make check fix make check and fix usage with node 0.10 Nov 5, 2019
@trentm
Copy link
Contributor

trentm commented Nov 5, 2019

http-signature@1.3.1 is now published with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants