Merged
Conversation
conradludgate
previously approved these changes
Dec 28, 2022
For clearer control over connection timeouts.
At the request of clippy
ThomWright
force-pushed
the
connect-timeout
branch
from
077110c to
d1b30d0
Compare
conradludgate
previously approved these changes
Apr 2, 2023
Contributor
conradludgate
left a comment
conradludgate
left a comment
There was a problem hiding this comment.
Do we want some safe defaults here? If I specify just a timeout but no connect_timeout, should the connect_timeout be assumed to be the same as timeout?
Co-authored-by: Conrad Ludgate <oon@conradludgate.com>
Member
Author
I like this idea. Done. |
conradludgate
approved these changes
Apr 3, 2023
Member
Author
|
I apparently don't have write access to merge 🥺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
connect_timeout()option toLoadBalancedChannelBuilder.Relevant to #37.
Note: hyperium/tonic#1215 will need merging first for this to work.