@turf/boolean-valid is not part of turf and fails to build due to missing depedency

[JamesLMilner]

Firstly thanks for all your hard work on this fantastic library.

I wanted to point out a couple issues with boolean-valid. If boolean-valid does not seem to be be part of @turf/turf. I'm not sure if this is intentional? To reproduce do npm install @turf/turf and try and use turf.booleanValid.

Also, there appears to be a dependency on boolean-disjoint. I'm not sure if this should be specified in the depdencies here

turf/packages/turf-boolean-valid/package.json

Line 50 in b3b5284

"dependencies": {

?

To reproduce second issue:

import { Feature } from 'geojson';

import booleanValid from '@turf/boolean-valid';

export function featureIsValid(feature: Feature): boolean {
    return booleanValid(feature);
}

Without install boolean-disjoint results in:

ERROR in ../node_modules/@turf/boolean-disjoint/index.js
Module build failed: Error: ENOENT: no such file or directory, open '/home/james/Code/dentreality/customer-portal/node_modules/@turf/boolean-disjoint/index.js'
 @ ../node_modules/@turf/boolean-valid/dist/es/index.js 3:0-53 107:13-28

[rowanwins]

Hey @JamesLMilner

There is some history back here #1302 regarding this, it was pretty rough when it got merged which is why it never made it into main package.

Sounds like you found a legit issue with an easy fix for the dependencies, but on the whole the module probably needs some more love.

Is there a particular validation you're after out of interest?

[JamesLMilner]

@rowanwins thanks for follow up, helpful to know. Does sound like an easy fix, I could look at raising it if you'd like?

Nothing in particular, we just had issues where we went to save invalid geometries and were looking for something that would help us prevent that from happening and this seemed like a good module to achieve that. Basically we were just looking to make sure LineStrings and Polygons in particular were well formed (i.e. had minimum number of coordinates and closed correctly)

[mfedderly]

I think this was fixed by #2094