pointOnLine is not giving true closest point

[bulutkartal]

Technically closest point should be where the point has right angle with line. Following example shows snapped point is off and actually it is not the closest point on the line.

Jsfiddle example is here.

[bulutkartal]

Can this be bc of projection difference as well?

[DenisCarriere]

I'm thinking it might be a Google Maps projection (Leaflet would be the same).

🤔 Not too sure.

[bulutkartal]

When I use pointToLineDistance , and set mercator as true, it gives me the right distance. but on snapped distance it is different than pointToLineDistance. and there is no option for mercator in pointOnLine.

[DenisCarriere]

@bulutkartal Feel free to send a PR with an option for mercator. 👍

[bulutkartal]

I wish I could but I am not that talented when it comes to js :) Is there a way to use turf projection with js? turf.min.js seems like it doesn't include turf projection.

[bulutkartal]

I think it is not a projection problem, it seems calculation problem to me. Google maps uses WGS84 and I shouldn't set mercator true to be able to find the right distance.

here is the google maps coordinate information.

Since turf and google maps uses WGS84 I can't figure out what is causing this.

[DenisCarriere]

@bulutkartal send a PR with your test case to packages/turf-point-on-line/test.js

[bulutkartal]

@DenisCarriere , I am really not that advanced to be able to do it :( I am sorry. I prepared another fiddle showing snapped position is kinda off on mapbox as well. So it is not google maps, it is turf :(

[bulutkartal]

@DenisCarriere I checked but I couldn't do the pull request. I ve never done this before.

[DenisCarriere]

I've never done this before.

Better late then never right? 😄

GitHub has tons of documentation to get you started, here's one that might help you start:
https://help.github.com/articles/fork-a-repo/

[bulutkartal]

@DenisCarriere thank you for the information. But I don't know anything abt testling or tape. So I won't be able to make changes on packages/turf-point-on-line/test.js in correct way. All I will do is just copy and paste the coordinates from my fiddles. I am a great user but not a developer :) Fiddles show there is an issue with pointOnLine, but I am really far from doing what did you ask me to do :) Sorry for that. I love the functions you guys provided with turf.js but this is all I can do for now.

[bulutkartal]

@DenisCarriere , @rowanwins , @stebogit do you guys plan to fix this issue? I will either use pointToLineDistance distance on my project or wait until next version if this will be fixed :)

[stebogit]

@bulutkartal I wanted to work on this issue, but we recently decided to go for the next major release (v5.0) which will take few weeks.
I'll probably spend all my "contributor time" on that, but later I'll definitely get back to this (unless somebody else fixed it in the meanwhile 😄 ).