Issue 2342 - Handle when start and end are the same point in greatCircle #2343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfedderly
reviewed
Aug 5, 2024
Collaborator
mfedderly
left a comment
mfedderly
left a comment
There was a problem hiding this comment.
This looks like something we should merge. Do you have time to fix up the merge conflicts? I think that the CHANGELOG.md change can just be dropped because we are calculating them from the PR titles now.
Member
|
Will take a look and get ready to merge. |
smallsaucepan
approved these changes
Oct 15, 2024
Member
|
Ready to merge if you're still happy @mfedderly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an array of NaN's coming back when start and end points are the same.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.Resolves #2342