Changed lineSplit to use bbox from geojson-rbush rather than buggy turf-square#2460
Merged
smallsaucepan merged 12 commits intoTurfjs:masterfrom May 25, 2025
Merged
Changed lineSplit to use bbox from geojson-rbush rather than buggy turf-square#2460smallsaucepan merged 12 commits intoTurfjs:masterfrom
smallsaucepan merged 12 commits intoTurfjs:masterfrom
Conversation
hanneshdc
changed the title
Collaborator
|
I'd like to merge this. Any chance you have time to clean up the merge conflicts first? |
added 8 commits
November 21, 2024 22:42
…o results in more efficient checks
This is handled by geojson-rbush already.
hanneshdc
force-pushed
the
issue-1232
branch
from
bfa79ea to
0da7ada
Compare
Contributor
|
Hi, what's the reason for closing this PR? Was is solved in another PR? |
Author
|
@kudlav not sure what happened! GitHub seems to have automatically closed it when I rebased the branch. Have re-opened. |
smallsaucepan
changed the title
…ntioned in issue Turfjs#1232, as well as Turfjs#2288 which this PR also helps address. Tidied up some test file Typescript errors.
smallsaucepan
approved these changes
May 24, 2025
Member
|
Thanks for doing this @hanneshdc. Sorry it took so long to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1232.
Resolves #2288
The cause of the issue is the application of
turf-squareto feature bounding boxes, which sometimes incorrectly results in a smaller bounding box. While this is really a bug inturf-square, the application isn't needed here. Instead, we can remove the bbox calculation completely and allowgeojson-rbushto calculate it for us instead.From the template:
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.Submitting a new TurfJS Module. (N/A)