turf-nearest-point: maintain point properties in result type#2866
Merged
twelch merged 1 commit intoTurfjs:masterfrom Apr 8, 2025
Merged
turf-nearest-point: maintain point properties in result type#2866twelch merged 1 commit intoTurfjs:masterfrom
twelch merged 1 commit intoTurfjs:masterfrom
Conversation
…ts in the FeatureCollection
1 task
twelch
approved these changes
Apr 8, 2025
Collaborator
twelch
left a comment
There was a problem hiding this comment.
Confirmed in light testing that user-provided properties are properly flowing through to the returned type, while also picking up featureIndex and distanceToPoint.
Collaborator
|
Thank you @EmilJunker for improving this. It will become available in the next release, timing TBD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
NearestPointtype and the type definition for thenearestPointfunction.Consider the following example in TypeScript:
With the old behaviour
myNearestPoint.properties.nameis of typeanyaccording to TypeScript.With the changes in this PR, the type of
myNearestPoint.properties.nameis correctly inferred asstring.This change should be non-breaking.
This PR replaces #2861.
Please provide the following when creating a PR: