fix(client): improve udp support with probe#1631
Open
gusandrioli wants to merge 2 commits into
Open
Conversation
Signed-off-by: Gustavo Andrioli <gusaandrioli@gmail.com>
Signed-off-by: Gustavo Andrioli <gusaandrioli@gmail.com>
gusandrioli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1536
UDP endpoints with
[CONNECTED] == truealways reported as healthy, even for closed ports.net.DialTimeouton UDP always succeeds (UDP is connectionless), so a probe byte is sent after dialing. If the port is closed, the OS returns an ICMP port-unreachable which surfaces asECONNREFUSEDon the subsequent read, marking the connection as failed. A timeout/no-response is treated as success (normal for silent UDP services).Checklist
README.md, if applicable.