Conversation
julienchastang
force-pushed
the
https
branch
9 times, most recently
from
c251d75 to
7ff08e5
Compare
ethanrd
left a comment
ethanrd
left a comment
There was a problem hiding this comment.
We've been reviewing Unidata XLM Namespace URIs given the changes necessitated by the webmod2 project.
I've suggested some changes to this PR based on that discussion (for both Unidata and other XML Namespace URIs).
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <p:resource xmlns:p="http://datacite.org/schema/kernel-3" | |||
There was a problem hiding this comment.
XML Namespace URIs are just unique strings that, by convention, usually happen to look like HTTP URLs.
They should not be changed to update "http:" to "https:".
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <catalog xmlns="https://www.unidata.ucar.edu/namespaces/thredds/InvCatalog/v1.0" xmlns:xlink="http://www.w3.org/1999/xlink" name="Latest Unidata IDD Model Data" version="1.0"> | |||
There was a problem hiding this comment.
The Unidata XML Namespace URIs should be changed back to start with "http:".
The XLink namespace URI should not be changed.
Of course, I notice the motherlode:8080 URLs which are defunct. So ... ?
| @@ -1,11 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <catalog name="LEAD TestBed IDV Data" version="0.6" | |||
| xmlns="http://www.unidata.ucar.edu/thredds" | |||
There was a problem hiding this comment.
Wow! This XML Namespace must be very old. We've used the www.unidata.ucar.edu/namespaces/* URIs for a very long time.
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <catalog xmlns="https://www.unidata.ucar.edu/namespaces/thredds/InvCatalog/v1.0" xmlns:xlink="http://www.w3.org/1999/xlink" name="Latest Unidata IDD Model Data" version="1.0"> | |||
There was a problem hiding this comment.
Here again the Unidata Namespace URIs should be changed back to "http:" and the XLink ones should not be changed to "https:".
| @@ -1,8 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <catalog xmlns="https://www.unidata.ucar.edu/namespaces/thredds/InvCatalog/v1.0" xmlns:xlink="http://www.w3.org/1999/xlink" name="TREX Catalog"> | |||
There was a problem hiding this comment.
And again, the Unidata and XLink URIs ...
I won't comment on any remaining ones. Probably all the "xmlns" attributes should be reviewed.
|
|
||
| /** xml items */ | ||
| public static final String XMLNS_XMLNS = | ||
| "http://a9.com/-/spec/opensearch/1.1/"; |
There was a problem hiding this comment.
Just noting these which aren't in XML files ...
| <action name="Catalog4" url="/ucar/unidata/idv/chooser/catalog4.xml"/> | ||
| <action name="Contained test" > | ||
| <datasetChoice name="NEXRAD Level 3 Radar" | ||
| actiontemplate="http://motherlode.ucar.edu/cgi-bin/thredds/RadarServer.pl?stn=FTG&product=N0R&time=1hour"> |
There was a problem hiding this comment.
Any motherlode.ucar.edu URLs are probably no longer available. I think motherlode redirects to atm.ucar.edu but I'm pretty sure there hasn't been any cgi-bin content in quite some time.
2 participants
No description provided.