Implement close functions for UMachine and USolver classes
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeypospelov
approved these changes
May 25, 2023
DaniilStepanov
pushed a commit
that referenced
this pull request
Nov 15, 2024
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Apr 18, 2025
* add spy support * style fixes
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
May 5, 2025
* add spy support * style fixes
Saloed
pushed a commit
that referenced
this pull request
Jun 2, 2025
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Jun 19, 2025
* add spy support * style fixes
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Aug 15, 2025
* add spy support * style fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to implement
closefunctions in UMachine and USolver classes. It caused a bug when analysis never ends due to unreleased native resources inKYicesSolverin UMachine.For now, I made UMachine responsible for closing a solver instance, but later we might change it if we want to make
UComponentsa shared instance between different machines.