Memory composition support #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaelmBleidd
force-pushed
the
caelmbleidd/map_regions
branch
from
af17fd7 to
a065454
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/map_regions
branch
from
a065454 to
11cf1a5
Compare
sergeypospelov
requested changes
Mar 6, 2023
Member
|
I am not sure about fun <RegionId : URegionId, Key, Sort : USort> memcpy(
fromKey: Key,
toKey: Key,
fromRegion: UMemoryRegion<RegionId, Key, Sort>
) |
- RegionId made generic - No instantiator constructors - Composer is less than 70 lines now - No unclear heap interfaces extensions - Memcpy is entirely implemented
sergeypospelov
requested changes
Mar 15, 2023
Member
sergeypospelov
left a comment
sergeypospelov
left a comment
There was a problem hiding this comment.
Please, add tests on composition of URangeUpdateNodes.
CaelmBleidd
commented
Mar 16, 2023
CaelmBleidd
force-pushed
the
caelmbleidd/map_regions
branch
from
5ed85f7 to
7ff8aa1
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/map_regions
branch
from
1f0af7f to
be28b95
Compare
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Apr 4, 2025
* update type argument rendering logic * fix mockMvc1 field name, when mockMvc not present * add JcSpringImportManager * remove redundant cp argument from annotations * JcDeadCodeTransformer rework * update jacodb version * fix lint * remove redundant check * remove redundant super calls
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
May 5, 2025
* update type argument rendering logic * fix mockMvc1 field name, when mockMvc not present * add JcSpringImportManager * remove redundant cp argument from annotations * JcDeadCodeTransformer rework * update jacodb version * fix lint * remove redundant check * remove redundant super calls
Saloed
pushed a commit
that referenced
this pull request
Jun 2, 2025
* Add support for memory composition * Review fixes * Composition refactoring and array copying implementation - RegionId made generic - No instantiator constructors - Composer is less than 70 lines now - No unclear heap interfaces extensions - Memcpy is entirely implemented * Refactoring * Review fixes --------- Co-authored-by: Dmitry Mordvinov <[email protected]>
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Jun 19, 2025
* update type argument rendering logic * fix mockMvc1 field name, when mockMvc not present * add JcSpringImportManager * remove redundant cp argument from annotations * JcDeadCodeTransformer rework * update jacodb version * fix lint * remove redundant check * remove redundant super calls
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Aug 15, 2025
* update type argument rendering logic * fix mockMvc1 field name, when mockMvc not present * add JcSpringImportManager * remove redundant cp argument from annotations * JcDeadCodeTransformer rework * update jacodb version * fix lint * remove redundant check * remove redundant super calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for memory composition.
Minor changes:
UContextwith values fromKContextUConcreteHeapRefRegionIdgeneric parameter in many placesUMemoryRegionsfile into three:MemoryRegions,UMemoryUpdates, andUpdateNodes, containing corresponding classes and their inheritors.isEmptyreturning true for theUniverseregionUFlatUpdatesUnsolved problems:
keyMapperis still an uncomposable object, that leads to a problem with recalculation of lower bounds in lambda closure inside theURangedUpdateNodeOpen questions:
memcpyfunction contain a memory region? Can we have a heap without regions?writeArrayLength? Create an abstract class? Or an external interface? Or implement a default behaviour throwing an errorAdded tests:
org.usvm.MapCompositionTestfor map operations in different classesorg.usvm.MemoryRegionTests#testMultipleWriteTheSameUpdateNodefor key deduplicationorg.usvm.CompositionTestfor composition as an operation