Merged
Conversation
The format string was incorrect in this case, which leads to this crash in Unity: https://crashes.hq.unity3d.com/crashes/5aa00d01b4db11000de20c8e?versions_range=2018.3.5..2019.2.99&date_start=&date_end=&source= Simply remove the unused `%s` format specifier here.
joncham
approved these changes
Mar 11, 2019
Member
|
This is still an issue upstream. We should open PR there too https://github.com/mono/mono/blob/master/mono/metadata/threadpool-io.c#L201 |
Author
|
Yes, I'll fix this upstream as well. |
Author
|
I've back ported this to 2019.1 at: 256ceb9 |
Author
|
I've back ported this to 2018.3 at: 9022a35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format string was incorrect in this case, which leads to this crash
in Unity:
https://crashes.hq.unity3d.com/crashes/5aa00d01b4db11000de20c8e?versions_range=2018.3.5..2019.2.99&date_start=&date_end=&source=
Simply remove the unused
%sformat specifier here.I'm planing to back port this change to 2019.1 and 2018.3.
Release notes:
Mono: Fix an intermittent crash in strnlen, from the selector_thread_wakeup_drain_pipes function.
I'll also upstream this fix once it lands in our repo.