feat!: project-e2kを移植#1186
Draft
qryxip wants to merge 17 commits into
Draft
Conversation
Co-authored-by: Hiroshiba <hihokaruta@gmail.com> Co-authored-by: Hiroshiba Kazuyuki <kazuyuki_hiroshiba@dwango.co.jp> Co-authored-by: takana-v <44311840+takana-v@users.noreply.github.com> Co-authored-by: sevenc-nanashi <sevenc7c@sevenc7c.com> Co-authored-by: tarepan <tarepan5884@gmail.com>
qryxip
force-pushed
the
pr/feat-project-e2k
branch
from
3377721 to
4f16962
Compare
qryxip
added a commit
that referenced
this pull request
Oct 31, 2025
ちょうどよい機会なので、 #1186 の前にやってしまう。 `core::infer::runtimes::onnxruntime`にも同様のTODOがあるが、そちらは後回 しにする。
qryxip
force-pushed
the
pr/feat-project-e2k
branch
from
5bd5a42 to
8b8cf3c
Compare
This was referenced Mar 10, 2026
qryxip
added a commit
that referenced
this pull request
May 4, 2026
#1186 内でdeny.tomlを更新するときに発見。どうやら`hash`が間違っていると 宣言自体がサイレントに読み飛ばされるらしい。 > Note: your premise is off — that `ring-0.17.11/LICENSE` (and the > `0.17.14` one cargo-deny actually consumes; Cargo.lock pins > `ring 0.17.14`) hashes to `0x0d99693a` under the current cargo-deny > algorithm, not `0xbd0eed23`. The `0xbd0eed23` value in `deny.toml:182` > was originally written for `ring 0.16` (see > `git log -S 0xbd0eed23 -- deny.toml`) and was carried forward to the > 0.17 entry without re-checking. cargo-deny silently ignores a clarify > entry whose `hash` doesn't match (it just falls back to askalono > detection), so the stale value hasn't been noticed. (注: `182`行目というのは #1186 での話) なおそもそも`hash`というのは何なのかというと、 > `twox_hash::XxHash32` over the file content with `\r\n` → `\n` > normalization, see `gather.rs::get_file_source` and `lib.rs::hash` らしい（私の知る限りundocumented）。 Assisted-by: Claude Code:claude-opus-4-7 Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
# Conflicts: # crates/voicevox_core_java_api/lib/src/main/java/jp/hiroshiba/voicevoxcore/blocking/Synthesizer.java # crates/voicevox_core_python_api/src/lib.rs # deny.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
以下の4名の許諾のもと #874 にのっとりMITライセンスとしてライセンスする。
should_convert_english_to_katakana()の呼び出しを減らす voicevox_engine#1713)ただし、以下の貢献部分については含まないものとする。
<175728472+Copilot@users.noreply.github.com>(本PRではモーラカウント部分の新規追加はしていないため)<noreply@github.com>によるマージコミットのauthorとして名前が出ているだけであるため)VOICEVOX/voicevox_engine#1733 で
<kazuyuki_hiroshiba@dwango.co.jp>が出現しているのは意図的ではなさそうだが、とりあえず<hihokaruta@gmail.com>と並ぶ形でco-authorに追加することにする。関連 Issue
Resolves: #1161
その他