Allow setting new value for OSRM snapping radius

[SimonBradley1993]

We have an issue where Vroom is assigning jobs to vehicles where there is no valid route, due to OSRM snapping from the nearest location to the job location. I see that Vroom sets quite a high radius value of 35000m. It'd be really useful if we can adjust this value with config to allow us to set this much lower.

[jcoupey]

The rationale for setting a very high value was to not change too much previous behavior when introducing the filtering, while erroring on typical mistakes (e.g. lon,lat mixup). But I agree we should probably use a smaller default value.

As for adjusting the value to your needs, that is definitely possible:

vroom/src/structures/typedefs.h

Line 59 in 004faa4

const std::string DEFAULT_OSRM_SNAPPING_RADIUS = "35000";

[SimonBradley1993]

Hi Julien,

I'm trying now to experiment with having this value set to a different one. I don't seem to have the rights to push a branch to the vroom repo to then pull that branch with Vroom docker.

Are you able to give me permissions to push a new branch?

Thanks

[SimonBradley1993]

Forget that, I've realised I need to use my fork to do this

[SimonBradley1993]

Hi Julien,

I've been testing some changes to Vroom in relation to this issue. I've come across a check that happens for null values when parsing the OSRM response. This is the function that is doing this check check_unfound in wrapper.h.

After making my OSRM snapping radius change, we get expected null values coming back from OSRM. This is due to some of our vehicles being located on islands, meaning that they won't have any route to jobs or other vehicles on the mainland. When running these requests through Vroom we then get errors coming back from the check_unfound function that stops the process.

The expected behaviour for us would be that vehicles that don't have a valid route to jobs would not be assigned those jobs, instead of the whole process being stopped. When I remove this check we get this behaviour and can add more jobs to islands where there are vehicles located.

Would removing this check be something that you would be able to / want to do in Vroom?

[SimonBradley1993]

Hi Julien,

I've opened a couple of PR's that would allow us to configure the snapping radius for OSRM :

#1332
VROOM-Project/vroom-express#115

I appreciate I've probably missed some things, especially with the Vroom PR. I'm happy for you to modify it as you like, if you want this feature in.

I've tested this locally with vroom-express and it works as expected, adjusting the radius query parameter values sent to OSRM.