overlay: phase 0 review 2 — scheduled evidence remains

docs/overlay/handoffs/phase-0-fix.md

@@ -31,8 +31,11 @@ branch `overlay/phase-0-fix` · worktree `/home/verox/src/t3code-phase-0` · PR:
 ## Developer actions
 
 - After this PR merges: `gh workflow run overlay-release.yml --ref overlay/main -f version=0.1.3-overlay.1`, then `gh run watch <id>` and `gh release list`. Record the run URL and the draft `overlay-v0.1.3-overlay.1` with `T3-Code-*.exe`, its blockmap and `latest.yml` in the re-review.
+  Result: installer run https://github.com/VeroxAUS/t3code/actions/runs/40833226635 succeeded
+  Result: draft release overlay-v0.1.3-overlay.1 with T3-Code-0.1.3-overlay.1-x64.exe, .blockmap and latest.yml: https://github.com/VeroxAUS/t3code/releases/tag/untagged-5ecdc6ba2719b0a3a79a
 - After 2026-10-30 03:17 UTC: `gh run list --workflow overlay-sync.yml --json databaseId,event,conclusion,createdAt,url`; record the run with `event: schedule`. Do not dispatch another manual run in its place. If none appears, check that the workflow is enabled.
 - Usage-strip render pass (finding 2): either run it from a T3 Code session that has the Browser panel (seeded `vp run dev`, a provider with quota data such as `Replay (dev)`, one screenshot of the strip), or look at the strip yourself and record the environment, provider and screenshot here.
+  Result: usage strip renders with the Replay (dev) provider; screenshot at C:\Users\Thomas\status.png
 
 ## Open questions for the developer
 

docs/overlay/handoffs/phase-0-review-2.md

@@ -0,0 +1,41 @@
+# Handoff · Phase 0 · Review 2 · 2026-10-29 · written by Codex
+
+status: findings
+
+commit: 702d399609
+supersedes: docs/overlay/handoffs/phase-0-fix.md
+
+## Findings
+
+1. {file: `docs/overlay/handoffs/phase-0-fix.md`, line: 36, severity: medium, claim: The scheduled-sync review criterion still lacks evidence., evidence: `gh run list --repo VeroxAUS/t3code --workflow overlay-sync.yml --json databaseId,event,conclusion,createdAt,url` returns only successful manual run 40822950375, created 2026-10-29T05:21:44Z, and no schedule event. The workflow declares `17 3 * * *`; the next execution is due 2026-10-30 at 03:17 UTC. This is an outstanding evidence gate, not a demonstrated scheduling defect., suggested fix: After the scheduled execution, record its URL, event and conclusion in the fix handoff and request another review. Do not substitute a manual dispatch. If it does not appear, inspect workflow enablement.}
+
+## Done, verified
+
+- Review PR: https://github.com/VeroxAUS/t3code/pull/13 into `overlay/main`.
+- Re-read the Phase 0 roadmap, every Phase 0 handoff, fork decision, architecture, execution plan, manifest and applicable final-review briefs. Inspected PR 12's diff and the cumulative implementation diff from v0.1.3; the prior review records the original PR-diff review. No implementation changes made.
+- Prior finding 1 cleared: `gh run view 40833226635 --repo VeroxAUS/t3code --json conclusion,event,url,jobs` reports success for checkout, Windows installer build and draft release. Run: https://github.com/VeroxAUS/t3code/actions/runs/40833226635. `gh api repos/VeroxAUS/t3code/releases` confirms draft `overlay-v0.1.3-overlay.1` with `T3-Code-0.1.3-overlay.1-x64.exe`, its `.blockmap`, and `latest.yml`: https://github.com/VeroxAUS/t3code/releases/tag/untagged-5ecdc6ba2719b0a3a79a. No dispatch or release mutation repeated.
+- Prior finding 2 cleared: inspected `/mnt/c/Users/Thomas/status.png` (the handoff's `C:\Users\Thomas\status.png`). It visibly shows Codex and Claude session/weekly remaining quota and reset countdowns above the composer. The developer records `Replay (dev)` as the exercised provider and explicitly owns the manual render pass. This is developer-supplied evidence; no browser or computer use was performed by this review.
+- Prior finding 4 cleared: inspected PR 12's separation of all changed paths from present paths. From `scripts`, `/home/verox/src/t3code-phase-0/node_modules/.bin/vp test run overlay-check.test.ts` passes all 7 tests, including the deletion-only regression. The test exercises a real temporary git repository and asserts a handoff is required. Initial sandbox subprocess EPERM was resolved by the authorized rerun.
+- Re-ran focused tests with `/home/verox/src/t3code-phase-0/node_modules/.bin/vp test run <paths>` from each owning package: contracts `src/settings.test.ts` → 30 passed; shared `src/projectSettings.test.ts` → 21 passed; desktop `src/updates` → 63 passed; server `src/telemetry src/cloud/selfUpdate.test.ts` → 37 passed; routing `src` → 1 passed. Server fixtures initially could not bind under the sandbox; the authorized rerun passed. These verify decoding defaults, settings patches, nested project overrides, global-only limits/telemetry, updater defaults and telemetry opt-in precedence.
+- `node scripts/overlay-check.ts --base v0.1.3` → pass, 20 upstream overlay files reconciled and routing test passed. `rg -l '// overlay:' apps packages knip.jsonc` → the same 17 marked paths as the manifest; the other three manifest entries are JSON/lockfiles. Markers and manifest agree in both directions.
+- `gh pr checks 7 --repo VeroxAUS/t3code` → overlay-check pass; `gh pr checks 8 --repo VeroxAUS/t3code` → expected overlay-check fail. `gh api repos/VeroxAUS/t3code/branches/overlay%2Fmain/protection` confirms required overlay-check, PR requirement and force pushes disabled. `gh repo view VeroxAUS/t3code --json defaultBranchRef` → overlay/main. Mutation evidence was inspected rather than repeated.
+- `uname -r` → WSL2; `node --version` → v26.12.1; `vp --version` → v1.4.0. Dev-server HTTP 200 transcripts remain in steps 0 and 4; successful installer execution and the developer's render evidence supplement those historical startup checks. Install and dev-server startup were not repeated in this re-review.
+- Promoted #17 is implemented and tested. Promoted #26 is recorded as set to Haiku 5.5 in the complete handoff's developer action result; its earlier unchecked box is stale.
+- Surface audit: ChatComposer mounts the strip for web and desktop; mobile was outside this phase's explicit port scope. No new mutation entry points, keybindings, RPC methods or adapter behavior. Primary-environment-only quota display remains the developer-accepted step-7 limitation. No new continuous animation or websocket stream.
+- Applicable final-brief checks: settings have decoding defaults and project overrides exclude global groups. No overlay database migration, privilege ceiling, ledger/replay, budget guard, session cache or model-facing instruction/tool-description change occurred; those later-phase checks and instruction evals do not apply here. Upstream preservation of unknown settings remains the final settings-migration review concern recorded in review 1.
+- `gh api repos/VeroxAUS/t3code/actions/workflows/overlay-sync.yml` → state active. The missing scheduled run is not explained by a disabled workflow.
+- `vp run check:changed origin/overlay/main` → pass (format; code checks skipped for the two handoff-only changes). No repo-wide checks were run. The initial sandbox subprocess EPERM was resolved by the authorized rerun.
+
+## Not done / deferred
+
+- Scheduled-sync evidence remains open; Phase 0 cannot pass yet.
+
+## Developer actions
+
+- After 2026-10-30 03:17 UTC, run `gh run list --repo VeroxAUS/t3code --workflow overlay-sync.yml --json databaseId,event,conclusion,createdAt,url` and record the actual scheduled run. Investigate workflow state if no run appears.
+
+## Open questions for the developer
+
+- none
+
+Next: Run docs/overlay/prompts/_fix.md for phase 0 with handoff docs/overlay/handoffs/phase-0-review-2.md — on Claude Sonnet 5.5 High or GPT-6.1 Sol high