app/vlinsert/insertutil: optimize LogMessageProcessor

[vadimalekseev]

Describe Your Changes

Before this change, the logMessageProcessor incremented two global atomics for each inserted row, causing high contention and bottlenecking throughput on multi-core systems. This commit switches to per-flush atomic updates, significantly reducing the overhead.

goos: linux
goarch: amd64
pkg: github.com/VictoriaMetrics/VictoriaLogs/app/vlinsert/insertutil
cpu: AMD Ryzen 9 5950X 16-Core Processor
          │   old.txt   │               new.txt               │
          │   sec/op    │   sec/op     vs base                │
AddRow-32   71.23n ± 2%   53.84n ± 5%  -24.41% (p=0.000 n=30)

          │   old.txt    │               new.txt                │
          │     B/s      │     B/s       vs base                │
AddRow-32   6.341Gi ± 2%   8.389Gi ± 5%  +32.30% (p=0.000 n=30)

          │  old.txt   │              new.txt              │
          │    B/op    │   B/op    vs base                 │
AddRow-32   73.50 ± 7%   0.00 ± ?  -100.00% (p=0.000 n=30)

          │  old.txt   │            new.txt             │
          │ allocs/op  │ allocs/op   vs base            │
AddRow-32   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=30) ¹
¹ all samples are equal

Checklist

The following checks are mandatory:

• My change adheres to VictoriaMetrics contributing guidelines.
• My change adheres to VictoriaMetrics development goals.

[cubic-dev-ai]

No issues found across 3 files

[valyala]

@vadimalekseev , thank you for the performance improvement!

[cubic-dev-ai]

5 issues found across 192 files (changes from recent commits).

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="app/vmui/packages/vmui/src/components/Configurators/QueryEditor/LogsQL/parser.ts">

<violation number="1">
P2: Operator detection now uses the untrimmed part, so tokens like `AND ` or `OR ` (which include the trailing space added during splitting) won’t match and will be misclassified as filters. Trim before checking operators to preserve correct parsing.</violation>
</file>

<file name="app/vlagent/kubernetescollector/file_collector.go">

<violation number="1">
P2: Close the opened file before returning on fingerprint mismatch to avoid leaking file descriptors.</violation>
</file>

<file name="app/vmui/packages/vmui/src/components/Configurators/QueryEditor/LogsQL/utils.ts">

<violation number="1">
P2: The cursor/selection start is always shifted by the comment delta even when the insertion happens after the cursor (e.g., cursor in leading indentation). This makes the caret jump unexpectedly and misplaces the selection. Adjust deltaStart based on whether the cursor is after the insertion point.</violation>
</file>

<file name="app/vmui/packages/vmui/src/pages/OverviewPage/OverviewHits/OverviewHits.tsx">

<violation number="1">
P2: barsCount is used inside the effect but missing from the dependency array, so updates to barsCount won’t refresh the fetched data.</violation>
</file>

<file name="app/vmui/packages/vmui/src/components/Main/ShortcutKeys/ShortcutKeys.tsx">

<violation number="1">
P2: `withHotkey` disables the shortcut, but the tooltip always advertises the F1 hotkey. Consider hiding the shortcut label when `withHotkey` is false to avoid misleading users.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[valyala]

FYI, this pull request has been included in VictoriaLogs v1.45.0.