Skip to content

app/vmui: add search for filtering fields in expanded log entries#1378

Open
Loori-R wants to merge 1 commit into
masterfrom
vmui/expanded-log-fields-search
Open

app/vmui: add search for filtering fields in expanded log entries#1378
Loori-R wants to merge 1 commit into
masterfrom
vmui/expanded-log-fields-search

Conversation

@Loori-R
Copy link
Copy Markdown
Contributor

@Loori-R Loori-R commented May 4, 2026

Describe Your Changes

Add a search field for filtering log fields by name and value in expanded log entries in the Group tab. This makes it easier to inspect logs with many fields without using browser page search.

Changes

  • add search for filtering fields by name and value in expanded log entries in the Group tab
  • show search field only when a log contains more than 8 fields

Screenshots

image

@Loori-R Loori-R added the web-ui Issues related to the user interface: layout, styling, usability, or UI-specific bugs. label May 4, 2026
@Loori-R Loori-R force-pushed the vmui/expanded-log-fields-search branch from b0d59d2 to 01e3026 Compare May 4, 2026 11:38
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link
Copy Markdown
Member

@func25 func25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few nit comments

Comment thread app/vmui/packages/vmui/src/components/Views/GroupView/GroupLogsFields.tsx Outdated
@Loori-R Loori-R force-pushed the vmui/expanded-log-fields-search branch from 01e3026 to dc78cf4 Compare May 6, 2026 06:59
Copy link
Copy Markdown
Member

@arturminchukov arturminchukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just want to suggest an enhancement. Does it make sense to add a top-level search by fields? For example, you enter the fields you are looking for in the top of groups, and when you expand the log, you see the already filtered fields. This will be a little more convenient than re-entering the field name each time you expand the log.

@Loori-R
Copy link
Copy Markdown
Contributor Author

Loori-R commented May 6, 2026

Does it make sense to add a top-level search by fields? For example, you enter the fields you are looking for in the top of groups, and when you expand the log, you see the already filtered fields. This will be a little more convenient than re-entering the field name each time you expand the log.

I originally designed this feature more as a field inspector for a single expanded log entry.

Users already have ways to surface important fields directly in the log row (for example via show as message), so I’m not sure global field search is the best default UX here.

Possible alternatives:

  1. A single top-level search.

    • Might be confusing, since users could expect it to search log rows/messages rather than fields inside expanded entries.
  2. A shared state between multiple inner search inputs.

    • Solves the re-entering problem for multiple expanded entries.
    • However, the input still looks local while affecting other expanded entries as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web-ui Issues related to the user interface: layout, styling, usability, or UI-specific bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants