lib/logstorage: reject whitespace before LogsQL filter function args#1386
Open
func25 wants to merge 2 commits into
Open
lib/logstorage: reject whitespace before LogsQL filter function args#1386func25 wants to merge 2 commits into
func25 wants to merge 2 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
func25
force-pushed
the
strict-func-call-space
branch
from
3c49c72 to
fdd8ce4
Compare
Signed-off-by: Phuong Le <39565248+func25@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the LogsQL parser stricter by returning a parse error when there is whitespace between a filter function name and the opening parenthesis, such as
ip:ipv4_range (1.2.3.4, 5.6.7.8)Fixes #1385