Conversation
0fb01c9 to
77ab347
Compare
9005319 to
43b45c8
Compare
|
@valyala could you please take a look at this PR? |
app/vlinsert/splunk/splunk.go
Outdated
|
|
||
| // RequestHandler processes splunk insert requests | ||
| func RequestHandler(path string, w http.ResponseWriter, r *http.Request) bool { | ||
| if !strings.HasPrefix(path, "/services/collector/event") { |
There was a problem hiding this comment.
Should we support the /services/collector/raw and /services/collector/health endpoints?
In log collectors like Vector and FluentBit, you can choose between different event/raw modes.
See https://docs.splunk.com/Documentation/Splunk/8.0.0/RESTREF/RESTinput#services.2Fcollector.2Fraw
JFYI: I also noticed there is /services/collector/mint endpoint, but it looks like other log collectors do not support it: https://docs.splunk.com/Documentation/Splunk/8.0.0/RESTREF/RESTinput#services.2Fcollector.2Fmint
There was a problem hiding this comment.
no need to support mint, as it's deprecated, added /health support. Regarding raw not sure how should accepted data be treated. There's no strict boundary between type passed via sourcetype and received data. Also which source types should we automatically parse and which should just accept as is
605b052 to
351d07f
Compare
351d07f to
972e4b0
Compare
Describe Your Changes
-splunk.*cmd arguments were addedChecklist
The following checks are mandatory: