add a pprof wrapper to simplify profiling#893
Conversation
369b16d to
73bb3db
Compare
|
For those interested in how pprof finds the source code: https://github.com/google/pprof/blob/e611ec304b22ed2bc39c0fd534f71243962cdd8a/internal/report/source.go#L1006 |
73bb3db to
accdff6
Compare
accdff6 to
095433e
Compare
|
I like the script, though it might be nice for the Makefile to act as a single entry point for executing tools. Would it make sense to still keep the Makefile as the entry point and have it delegate to |
|
it can be a separate makefile with debug specific targets |
|
I am not sure about Makefile, because we already have the download gharchive script that is not listed in the Makefile. Let's wait for @valyala's feedback. |
|
I don't like this solution, since it is very complicated and fragile. I followed an alternative path and created a pull request for |
Describe Your Changes
Add a pprof wrapper to simplify running pprof with support for showing dependencies' source code.
Can be related: google/pprof#611 , golang/go#48601
Usage:
Checklist
The following checks are mandatory: