-
Notifications
You must be signed in to change notification settings - Fork 195
Closed
Description
All or most of victoriametrics custom resource definitions have .spec.image.tag and .spec.image.repository.
But there's no .spec.image.digest. What's the way to set image digest?
Setting tag to something like v1.123.0@sha256xxx... should work in theory.
However, in case of active license, the tag gets a special handling:
operator/internal/controller/operator/factory/build/defaults.go
Lines 978 to 997 in fcb9e74
| func addEntSuffixToTag(versionTag string) string { | |
| // expected version tag is: | |
| // vX.Y.Z with optional suffix - | |
| if !strings.HasPrefix(versionTag, "v") || strings.Count(versionTag, ".") != 2 { | |
| return versionTag | |
| } | |
| idx := strings.Index(versionTag, "-") | |
| if idx > 0 { | |
| suffix := versionTag[idx:] | |
| switch suffix { | |
| case "-enterprise", "-enterprise-cluster": | |
| case "-cluster": | |
| versionTag = versionTag[:idx] + "-enterprise-cluster" | |
| } | |
| } else { | |
| versionTag += "-enterprise" | |
| } | |
| return versionTag | |
| } |
It seems that it should work fine for values like
v1.123.0-enterprise@sha256xxx..., but I'm not sure if this won't suddenly break in the future.Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels