Change Error log to Info for PVC size increase#1373
Merged
f41gh7 merged 1 commit intoVictoriaMetrics:masterfrom May 22, 2025
Merged
Change Error log to Info for PVC size increase#1373f41gh7 merged 1 commit intoVictoriaMetrics:masterfrom
f41gh7 merged 1 commit intoVictoriaMetrics:masterfrom
Conversation
bertinm-gc
requested review from
AndrewChubatiuk,
Haleygo and
f41gh7
as code owners
Collaborator
|
Thanks for contribution! |
makasim
reviewed
May 23, 2025
| // probably, user updated pvc manually | ||
| // without applying this changes to the configuration. | ||
| logger.WithContext(ctx).Error(fmt.Errorf("cannot decrease PVC=%s size from=%s to=%s", pvc.Name, newSize.String(), existSize.String()), | ||
| logger.WithContext(ctx).Info(fmt.Sprintf("cannot decrease PVC=%s size from=%s to=%s", pvc.Name, newSize.String(), existSize.String()), |
Collaborator
There was a problem hiding this comment.
No, it's minor internal change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #1361