Skip to content

feature: add scrapeClass to VMAgent, VMServiceScrape, VMPodScrape, VMProbe#1549

Merged
f41gh7 merged 1 commit intoVictoriaMetrics:masterfrom
endesapt:feature-scrape-classes
Oct 21, 2025
Merged

feature: add scrapeClass to VMAgent, VMServiceScrape, VMPodScrape, VMProbe#1549
f41gh7 merged 1 commit intoVictoriaMetrics:masterfrom
endesapt:feature-scrape-classes

Conversation

@endesapt
Copy link
Contributor

Fixes: #1531
Prometheus Operator introduced scrapeClass to standardize common configurations such as relabeling rules, TLS certificates, and authentication. This PR is created to provide compatibility with Prometheus resources by adding scrapeClassName to VMServiceScrape, VMPodScrape, VMProbe, VMScrapeConfig and scrapeClasses to VMAgent that is similar to scrapeClasses of Prometheus CRD.

@endesapt
Copy link
Contributor Author

endesapt commented Oct 16, 2025

now i added scrapeClass only for ServiceScrape to get some feedback on my implementation in case this featured is not planned, my code is not ideal and i need to rethink it, or my help is not required. If everything is alright, i will add scrapeClass for the remaining resources

@f41gh7 f41gh7 self-assigned this Oct 16, 2025
@endesapt
Copy link
Contributor Author

I see that you self-assigned this task? Do you want us to work together or will u take this feature from here ? I would like to work on this if its not urgent and i am not against working together. It would be great if you tell your intentions so that there is no confusion.

@AndrewChubatiuk
Copy link
Contributor

AndrewChubatiuk commented Oct 17, 2025

hey @endesapt
thanks for a PR
self assigned in our case means "interested in" and "added to list of PRs that are planned to be reviewed"

Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@endesapt
Copy link
Contributor Author

Thats great, then i will add simillar functionality to other components.

@f41gh7 f41gh7 merged commit 51b4560 into VictoriaMetrics:master Oct 21, 2025
2 checks passed
@f41gh7
Copy link
Collaborator

f41gh7 commented Oct 21, 2025

Thats great, then i will add simillar functionality to other components.

I'll create a small follow up and add missing APIs.

@endesapt
Copy link
Contributor Author

Thats great, thanks for your fast responce!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for scrapeclass in VMServiceScrape, VMPodScrape, VMProbe

3 participants