Skip to content

reconcile: properly check deployment and statefulset ready status #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f41gh7 merged 1 commit into from
Oct 30, 2025
Merged

reconcile: properly check deployment and statefulset ready status #1588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ aliases:

**Release date:** 30 October 2025

* BUGFIX: [vmoperator](https://docs.victoriametrics.com/operator/): properly check `StatefulSet` ready status for `rollingUpdateStrategy: RollingUpdate`. See this issue [#1579](https://github.com/VictoriaMetrics/operator/issues/1579) for details.
* BUGFIX: [VLCluster](https://docs.victoriametrics.com/operator/resources/vlcluster/): fix `-storageNode` argument generation for vlinsert. Bug was introduced in [ff722eb](https://github.com/VictoriaMetrics/operator/commit/ff722eb3ba4e72765548b4353b5f370b42d143f7).

## [v0.64.0](https://github.com/VictoriaMetrics/operator/releases/tag/v0.64.0)
Expand Down
5 changes: 4 additions & 1 deletion internal/controller/operator/factory/reconcile/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ func waitDeploymentReady(ctx context.Context, rclient client.Client, dep *appsv1
// (https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#complete-deployment)
// this function uses the deployment readiness detection algorithm from `kubectl rollout status` command
// (https://github.com/kubernetes/kubectl/blob/6e4fe32a45fdcbf61e5c30ebdc511d75e7242432/pkg/polymorphichelpers/rollout_status.go#L76)
if actualDeploy.Generation > actualDeploy.Status.ObservedGeneration {
if actualDeploy.Generation > actualDeploy.Status.ObservedGeneration ||
// special case to prevent possible race condition between updated object and local cache
// See this issue https://github.com/VictoriaMetrics/operator/issues/1579
dep.Generation > actualDeploy.Generation {
// Waiting for deployment spec update to be observed by controller...
return false, nil
}
Expand Down
5 changes: 4 additions & 1 deletion internal/controller/operator/factory/reconcile/statefulset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ func waitForStatefulSetReady(ctx context.Context, rclient client.Client, newSts
if err := rclient.Get(ctx, types.NamespacedName{Namespace: newSts.Namespace, Name: newSts.Name}, &stsForStatus); err != nil {
return false, err
}
if stsForStatus.Generation > stsForStatus.Status.ObservedGeneration {
if stsForStatus.Generation > stsForStatus.Status.ObservedGeneration ||
// special case to prevent possible race condition between updated object and local cache
// See this issue https://github.com/VictoriaMetrics/operator/issues/1579
newSts.Generation > stsForStatus.Generation {
return false, nil
}
if *newSts.Spec.Replicas != stsForStatus.Status.ReadyReplicas || *newSts.Spec.Replicas != stsForStatus.Status.UpdatedReplicas {
Expand Down
Loading