Conversation
Previously, due to race condition between local client cache and actual Kubernetes api-server, operator may incorrectly track ready status for Deployment and StatefulSet. client.Update(object) call increments `Generation` field of the update object if there was any change. While, client.Get(object) may not yet have this change. So this commit explicitly checks if updateObject.Generation is greater than getObject.Generation, to prevent such case. Fixes #1579
AndrewChubatiuk
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, due to race condition between local client cache and actual
Kubernetes api-server, operator may incorrectly track ready status for
Deployment and StatefulSet.
client.Update(object) call increments
Generationfield of the updateobject if there was any change. While, client.Get(object) may not yet have this change.
So this commit explicitly checks if updateObject.Generation is greater
than getObject.Generation, to prevent such case.
Fixes #1579