543 default limit field values to 1000 in query builder#556
Merged
arturminchukov merged 3 commits intomainfrom Feb 6, 2026
Merged
Conversation
There was a problem hiding this comment.
2 issues found across 5 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/components/QueryEditor/QueryBuilder/components/QueryBuilderFilters/useFetchFilters.ts">
<violation number="1" location="src/components/QueryEditor/QueryBuilder/components/QueryBuilderFilters/useFetchFilters.ts:36">
P2: The field name cache never invalidates when `query`, `timeRange`, or `field` changes, so the hook can return stale field lists for a different context. Consider resetting the cache when those inputs change or keying the cache by them.</violation>
</file>
<file name="src/language_provider.ts">
<violation number="1" location="src/language_provider.ts:59">
P2: Escape `fieldValueFilter` before embedding it into the LogsQL query; otherwise quotes/backslashes in user input can break the query or inject additional filters.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
src/components/QueryEditor/QueryBuilder/components/QueryBuilderFilters/useFetchFilters.ts
Show resolved
Hide resolved
Loori-R
approved these changes
Feb 6, 2026
dmitryk-dk
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #543
Describe Your Changes
Added a limit on field values that are fetched in the query builder. You can configure the limit in the datasource settings.
Checklist
The following checks are mandatory:
Summary by cubic
Set a default limit of 1000 field values in the query builder to improve performance and avoid overwhelming dropdowns. The limit is configurable in datasource settings and field value search now filters on the server.
New Features
Refactors
Written for commit b6d6a47. Summary will update on new commits.