Internal variables for rules#1353
Draft
tomaskender wants to merge 17 commits intoVirusTotal:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: We want to reuse the value of an evaluated expression multiple times in a rule. This is useful not only for faster evaluation, but also for long definitions that would otherwise have to be copypasted multiple times in conditions and make them longer than they need to be.
Each rule has it's own internal variable scope.
External variables have preference over internal variables (a warning is thrown in such case).
Supported variable types: in theory everything and anything YR_OBJECT supports.
What's implemented: strings, ints, floats, bools
Syntax: