Concept implementation of Network.run_interactive() method#10
Open
jbaayen wants to merge 2 commits intoVitens:masterfrom
Open
Concept implementation of Network.run_interactive() method#10jbaayen wants to merge 2 commits intoVitens:masterfrom
jbaayen wants to merge 2 commits intoVitens:masterfrom
Conversation
to dynamically inject input data on every time step.
Member
|
I see the added value of an interactive runloop using The solution I propose is refactoring the module to have one single interactive: Boolean # if set to True, use yield()
duration: Integer # if set to 0, calculate steady state
hydraulic_step: Integer
report_step: Integer
...etc..We can still keep the existing |
Contributor
Author
|
Sounds good to me. Will refactor accordingly. |
generator, depending on the options specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are dealing with an application where we have some of our controllers implemented in Python. These need to read the current system state at every time step, compute control output, and feed the control output back into EPANET.
In this concept implementation, control is passed back to the caller subsequent to every time step using
yield().I don't like the idea of having many flavours of
run()methods and would therefore like to use this pull request to open the discussion as to the design of a generic runner method, able to satisfy all relevant use cases.