feat: babel import assertions plugin#2
Conversation
AyAyEm
force-pushed
the
import-assertions
branch
from
042ed79 to
e666805
Compare
|
pretty sure that language feature requires 18 |
that's actually a 16 feature as well https://nodejs.org/docs/latest-v16.x/api/esm.html#json-modules |
|
that is only in v18+ |
|
that still doesn't fix it on v12-14... so we either remove compatibility with those versions or...? |
|
This pr only changes the esm config, and adds the support for assertions, if you try to use it in v12 it'll just throw an error, or maybe i didn't understand the concern? |
|
my concern is the ci is literally failing... |
|
there's a CI error it should run I just runed in v12 in my computer and it seems fine |
|
i've put that fix in #3, feel free to approve that and i'll approve this one assuming it still passes after rebase |
|
i'll reiterate what i mentioned on the other. i'm fine with the language feature being available from our lint config, but given that it's still in experimental support on node 16, i'm not cool with it running a lot of our critical build support |
|
Well it's your choice to close it or merge, i'm fine with any of the options |
|
well, shoot, i forgot to ask you to update the docs on the first page for esm |
# [1.3.0](v1.2.0...v1.3.0) (2022-11-28) ### Features * babel import assertions plugin ([#2](#2)) ([a450f8a](a450f8a))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
What did you fix?
Add compatibility to ESM import assertions that node uses
Reproduction steps
@babel/plugin-syntax-import-assertionsas dependencyesm.jsbabel plugins sectionimport/extensionsinesm.jsrules to alwaysEvidence/screenshot/link to line
Considerations