Add french bible versions for verses#264
Open
rjorel wants to merge 1 commit intoWP-for-Church:devfrom
rjorel:dev
Open
Add french bible versions for verses#264rjorel wants to merge 1 commit intoWP-for-Church:devfrom rjorel:dev
rjorel wants to merge 1 commit intoWP-for-Church:devfrom
rjorel:dev
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes:
Checklist:
Brief description of the proposed change:
Hi, I added Bible versions for my native language.
Any other info:
I do not know if it's a choice to only have english versions, without possibility to select more versions among the list of possible ones on https://biblia.com, so I only added ones for French.
I did not find the code responsible for parsing verse abbreviations, but if you merge this PR and say to me how to do it, I would like to add french abbreviation parsing.
Regards.