Conversation
jrfnl
left a comment
There was a problem hiding this comment.
The ruleset should be updated for the deprecation of the WordPress.WP.TimezoneChange sniff.
For reference:
- Changelog for WPCS 2.2.0: https://github.com/WordPress/WordPress-Coding-Standards/releases/tag/2.2.0
- Changelog for WPCS 2.1.1: https://github.com/WordPress/WordPress-Coding-Standards/releases/tag/2.1.1
N.B.: nearly all of the new sniffs should probably be added to the theme review ruleset (like EscapedNotTranslated, ValidPostTypeSlug and the DateTime sniffs). This should be done in separate PRs, but those can be pulled as soon as this PR has been merged.
|
I like the idea, let me open up a new PR for this 👍 |
👍 I suggest for the update related to the deprecated sniff to go in this PR though as the old sniff will start throwing deprecation notices as of WPCS 2.2.0. |
You mean the |
It should (for now) be replaced by The Replacing the old sniff with the new code is one thing. |
17a2b4a to
baae535
Compare
|
@dingo-d Is it me or did you add additional new sniffs to this PR now anyway ? Those are new decision points and would be a reason to reject this PR. |
|
Oh, I thought that I'd put the new sniffs with the deprecation ones since they all come with the new version of the WPCS 🤷♂ I can remove them and open a new PR with those changes |
Bumped the version of the WPCS in the composer.json. Replaced the deprecated rule WordPress.WP.TimezoneChange with WordPress.DateTime.RestrictedFunctions.timezone_change_date_default_timezone_set rule.
baae535 to
8aa0e31
Compare
|
@dingo-d Thanks for removing those. Once the build passes, I'll merge this. |
No description provided.