Skip to content

HCP HippUnfold and Post HippUnfold Implementations#320

Open
glasserm wants to merge 15 commits intomasterfrom
hippunfold
Open

HCP HippUnfold and Post HippUnfold Implementations#320
glasserm wants to merge 15 commits intomasterfrom
hippunfold

Conversation

@glasserm
Copy link
Copy Markdown
Contributor

@glasserm glasserm commented Jan 8, 2025

This is an implementation of the current version of HippUnfold 1.5.2-pre.2: https://hippunfold.readthedocs.io/en/latest/. This requires the current development version of Connectome Workbench to use. The file organization is non-final and needs evaluation and comment. There are a variety of unfinished things marked with TODO. Some of these are pending comments and some pending a new planned HippUnfold 2.0 release.

For those who have local access, the data are in here: myelin/brainmappers/Connectome_Project/YA_HCP_Final/100307/T1w/HippUnfold and MNINonLinear/HippUnfold

…eliminary and is CERTAIN TO CHANGE including file organization given additional Connectome Workbench features needed, HippUnfold bugs discovered and further development and optimization needed.
*Add Support for multi-resolution meshes
*Add Spec Files
*Add Support for Dentate in cifti-matlab
*Support reading CIFTI files with dentate in cifti-matlab
*Use consistent hippocampal labels in CIFTI and volume
*Code cleanup
*Remove matlab hack and just recreate all CIFTI files
*Add some combined hippocampal and cerebral spec files
Copy link
Copy Markdown
Contributor

@demsarjure demsarjure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this and added some minor comments/discussion points.

Comment thread Examples/Scripts/SetUpHCPPipeline.sh
Comment thread HippUnfoldHCP/HippUnfoldHCP.sh
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh
Comment thread HippUnfoldHCP/HippUnfoldHCP.sh
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh Outdated
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh Outdated
Comment thread HippUnfoldHCP/HippUnfoldHCP.sh Outdated
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh Outdated
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh Outdated
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh Outdated
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh Outdated
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh Outdated
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh Outdated
glasserm and others added 2 commits January 11, 2025 10:49
Co-authored-by: Tim Coalson <coalsont@users.noreply.github.com>
Co-authored-by: Tim Coalson <coalsont@users.noreply.github.com>
Comment thread HippUnfoldHCP/PostHippUnfoldHCP.sh Outdated
make "Space" variable for the space BIDS tag to avoid collision
replace inconsistent HippUnfoldFolderOut variable name
@coalsont
Copy link
Copy Markdown
Member

I undid the "single loop body moved to function" and used a new variable for the space bids tag instead of clobbering Modality. I also made the physical output folder variable name consistent. Please test.

@mharms
Copy link
Copy Markdown
Contributor

mharms commented Feb 10, 2025

Just getting around to taking a look at this. So, is the next version of HippUnfold going to support direct specification of input files, rather than having to hack an intermediate "BIDS-style" input directory?

In terms of organization, I was wondering if it wouldn't be helpful to segregate all the *.surf.gii output files for the different mesh resolutions into their own surf directory, and same for all the *.shape.gii files, so that the *.dscalar.nii files more readily stand out on their own. (Yes, I know that would be different from the organization of the brain data, but this is a fresh chance to give a little more structure to the output organization).

Can you remind me, how does one actually view the tessellation of the surfaces? I tried zooming in a lot, but I still wasn't getting to see the actual triangles.

@glasserm
Copy link
Copy Markdown
Contributor Author

  1. That is the hope.
  2. I prefer to maintain parallelism with existing HCP organizations and not generate a bunch of subfolders.
  3. That is under the surface menu in Connectome Workbench.

@mharms
Copy link
Copy Markdown
Contributor

mharms commented Feb 11, 2025

3. That is under the surface menu in Connectome Workbench.

Ahh, found it. Surface -> Properties, and then change the "Drawing Type" to "Links (Edges)"

@glasserm
Copy link
Copy Markdown
Contributor Author

Now supports and depends upon HippUnfold Version 2.0.0.

*Suppress label to metric warnings in stderr
Comment thread HippUnfoldHCP/HippUnfoldHCP.sh Outdated
@demsarjure
Copy link
Copy Markdown
Contributor

demsarjure commented May 10, 2025 via email

Comment thread HippUnfoldHCP/HippUnfoldHCP.sh Outdated
@coalsont
Copy link
Copy Markdown
Member

A broader question...why is "HCP" contained in the folder name that the scripts are in, and in the script filenames? The fact that they are in this repository is good enough for all the other folders and scripts (SetUp... and related notwithstanding, because we expect some users to copy it outside the pipelines folder before editing it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants