Skip to content

Fix NaN handling for some instructions#8472

Merged
stevenfontanella merged 1 commit intomainfrom
fix-float-misc
Mar 16, 2026
Merged

Fix NaN handling for some instructions#8472
stevenfontanella merged 1 commit intomainfrom
fix-float-misc

Conversation

@stevenfontanella
Copy link
Copy Markdown
Member

@stevenfontanella stevenfontanella commented Mar 16, 2026 •
edited
Loading

  • Fix bit patterns for canonical and arithmetic NaNs
  • Canonicalize NaNs for float instructions covered by spec tests
  • Also remove equivalent tests in test/spec since they're the same as the upstream tests but with some previously-failing parts removed, and using older syntax for checking for NaNs
  • Fixes 12 spec tests

Part of #8261.

@stevenfontanella stevenfontanella changed the title Fix NaNs in spec tests Fix NaN handling for some instructions Mar 16, 2026
@stevenfontanella stevenfontanella marked this pull request as ready for review March 16, 2026 19:32
tlively
tlively approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@stevenfontanella stevenfontanella merged commit c874f5d into main Mar 16, 2026
17 checks passed
@stevenfontanella stevenfontanella deleted the fix-float-misc branch March 16, 2026 20:49
@stevenfontanella stevenfontanella mentioned this pull request Mar 16, 2026
Open
91 tasks
@stevenfontanella stevenfontanella mentioned this pull request Mar 26, 2026
Merged
stevenfontanella added a commit that referenced this pull request Mar 26, 2026
@stevenfontanella
Enable conversions.wast spec test (#8528)
3fb6c3b 
The test already passes and was likely fixed by #8472.
test/spec/conversions.wast is an old version of the upstream spec test
that wasn't updated. Remove it since we now test against the newer
version.

Part of #8261.
This was referenced Mar 31, 2026
Merged
Merged
stevenfontanella added a commit that referenced this pull request Apr 1, 2026
@stevenfontanella
Canonicalize NaNs from nearbyint (#8561)
ef18138 
Followup to #8558 and #8472. Part of #8261.
@rathann rathann mentioned this pull request Apr 20, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlively tlively tlively approved these changes

@kripken kripken Awaiting requested review from kripken

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenfontanella @tlively