Closed
Conversation
Added enhanced math helpers for i32 operations with optional logging to linear memory. The functions include addition, subtraction, and multiplication, with logging controlled by the WASM_RT_MATH_MEM_LOG directive.
sbc100
reviewed
Feb 10, 2026
Member
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
I don't see any callers of these new functions you are adding. Am I missing something.
Cam you give the PR a more descriptive title and description so we can understand what is rationale for this change is?
| * // Call the potentially-trapping function. | ||
| * my_wasm_func(); | ||
| * // Call the potentially-trapping function. | ||
| * my_wasm_func(); |
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * http://www.apache.org/licenses/LICENSE-2.0 |
| if (mem_addr < 65536) wasm_mem[mem_addr] = res; | ||
| #endif | ||
| return res; | ||
| } |
Member
There was a problem hiding this comment.
Did you mean to add these function both to the header and the source file? Normally I would expect them to be in just one of these places.
Author
There was a problem hiding this comment.
im sorry man, im new to coding, i dont know too much, and i just want to contribute, what it does it just adds some stuff like to make adding better and stuff. mb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced Math Helpers for i32 Operations. Please review this! i am new to coding, and this is my first PR.