fix brightness and some keyboard changes#1
Open
psifertex wants to merge 2 commits intoWillyJL:feat/m5stack-cardputer-advfrom
Open
fix brightness and some keyboard changes#1psifertex wants to merge 2 commits intoWillyJL:feat/m5stack-cardputer-advfrom
psifertex wants to merge 2 commits intoWillyJL:feat/m5stack-cardputer-advfrom
Conversation
10 tasks
Owner
If by that you mean my keyboard improvements PR, I have ported it to cardputer adv too in my development branch, I was waiting for either of the PRs to get merged to update the other one with that code. Thanks for the PR, I'll have a look later tonight. |
Author
|
I also implemented audio though I haven't done as much testing it appears to be working. Hopefully I'll get around to doing some more work on it and cleaning it up later but in case anyone else is interested in this I figured I'd at least mention it here: https://github.com/psifertex/meshtastic-firmware/tree/feat/m5stack-cardputer-adv-audio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I defaulted to high brightness and fixed the brightness menu not showing up in settings.
Also changed the keyboard input so arrow keys work without pressing FN before each one. I haven't yet merged the additional keyboard PR to try that out yet, this fixes the most immediate annoyance for me.
Next I'll investigate and and potentially that other keyboard PR.