Merged
Conversation
oandregal
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
oandregal
added
the
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
oandregal
force-pushed
the
update/simplify-case-transforms
branch
from
92f6244 to
d5b7600
Compare
Base automatically changed from
update/save-time-theme-json-escaping
to
master
January 13, 2021 18:12
oandregal
force-pushed
the
update/simplify-case-transforms
branch
from
d5b7600 to
be7737f
Compare
oandregal
commented
Jan 13, 2021
| if ( null === $case_mappings ) { | ||
| $case_mappings = array( | ||
| 'to_kebab_case' => array(), | ||
| 'to_camel_case' => array(), |
Member
Author
There was a problem hiding this comment.
We weren't using the to_camel_case anywhere, so I've deleted it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #28061
Clarifies a bit the use of the cache for case transformations.