Icons Registry: Extend search to include label and keywords fields#76481
Icons Registry: Extend search to include label and keywords fields#76481manhar-addweb wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @manhar@addwebsolution. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @manhar-addweb! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
a800b50 to
e7247eb
Compare
e7247eb to
e2798f0
Compare
|
Thank you for the PR, @manhar-addweb. This was actually addressed in #75878, which added search by label and was merged into trunk yesterday. It might be worth checking the latest trunk to see if the issue is already resolved. |
Thanks for the review! Closing this in favor of #75878. |
|
Thanks @im3dabasia I checked #75878 - it covers label search only. This PR also adds keywords field search as mentioned I noticed the manifest.php does not have keywords yet.
Should I proceed with this? |
What?
Extends
get_registered_icons()inWP_Icons_Registryto searchagainst
labelandkeywordsfields in addition toname.Why?
Currently the search parameter only matches icon names.
Part of SVG Icon API iteration for WordPress 7.1.
Closes #75715
How?
Updated the search logic in
get_registered_icons()to checkname, label, and keywords fields using stripos().
Testing Instructions
Updated the search logic in
get_registered_icons()to checkname, label, and keywords fields using stripos().
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools